Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial test suite #21

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Add initial test suite #21

merged 9 commits into from
Dec 11, 2024

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Dec 5, 2024 •
edited
Loading

Changes

  • 🎁 Add test suite for http module

matzew added 3 commits December 5, 2024 16:28
@matzew
adding deps
41cb91e 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Adding simple test... that works w/ 'poetry run pytest'
beb87ca 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
some try...
cc3b4c4 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@knative-prow knative-prow bot requested review from lance and matejvasek December 5, 2024 15:43
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2024
@matzew matzew changed the title WIP: Add min test Add initial test suite Dec 11, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@matzew
Copy link
Contributor Author

matzew commented Dec 11, 2024

/lgtm
but is partially my own PR 🤣

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 11, 2024

@matzew: you cannot LGTM your own PR.

In response to this:

/lgtm
but is partially my own PR 🤣

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lkingland
Copy link
Contributor

/lgtm
but it's partially my own PR as well... #rubberstamp

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@knative-prow knative-prow bot merged commit f359836 into knative-extensions:main Dec 11, 2024
13 checks passed
@matzew matzew deleted the add_min_test branch December 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance Awaiting requested review from lance

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @lkingland