Update pkg/reconciler/certificate/resources/cert_manager_certificate.go

Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
knative-extensions · Nov 14, 2023 · c699f69 · c699f69
1 parent aa66b6b
commit c699f69
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/pkg/reconciler/certificate/resources/cert_manager_certificate.go b/pkg/reconciler/certificate/resources/cert_manager_certificate.go
@@ -110,16 +110,15 @@ func MakeCertManagerCertificate(cmConfig *config.CertManagerConfig, knCert *v1al
 
 	dnsNames = append(dnsNames, knCert.Spec.DNSNames...)
 
-	var certType string
-	var ok bool
-	// default to CertificateExternalDomain if label is not set
-	if certType, ok = knCert.Labels[networking.CertificateTypeLabelKey]; !ok {
-		certType = string(netapi.CertificateExternalDomain)
+	// default to CertificateExternalDomain
+	certType := netapi.CertificateExternalDomain
+	if val, ok := knCert.Labels[networking.CertificateTypeLabelKey]; ok {
+		certType = netapi.CertificateType(val)
 	}
 
 	var issuerRef cmeta.ObjectReference
 	switch certType {
-	case string(netapi.CertificateClusterLocalDomain):
+	case netapi.CertificateClusterLocalDomain:
 		if cmConfig.ClusterLocalIssuerRef == nil {
 			return nil, &apis.Condition{
 				Type:    IssuerNotSetCondition,
@@ -130,7 +129,7 @@ func MakeCertManagerCertificate(cmConfig *config.CertManagerConfig, knCert *v1al
 		}
 		issuerRef = *cmConfig.ClusterLocalIssuerRef
 
-	case string(netapi.CertificateSystemInternal):
+	case netapi.CertificateSystemInternal:
 		if cmConfig.SystemInternalIssuerRef == nil {
 			return nil, &apis.Condition{
 				Type:    IssuerNotSetCondition,
@@ -141,7 +140,7 @@ func MakeCertManagerCertificate(cmConfig *config.CertManagerConfig, knCert *v1al
 		}
 		issuerRef = *cmConfig.SystemInternalIssuerRef
 
-	case string(netapi.CertificateExternalDomain):
+	case netapi.CertificateExternalDomain:
 		if cmConfig.IssuerRef == nil {
 			return nil, &apis.Condition{
 				Type:    IssuerNotSetCondition,