Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using knative.dev/pkg/pool, use errgroup instead #339

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

imjasonh
Copy link
Contributor

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 22, 2022

Welcome @imjasonh! It looks like this is your first PR to knative-sandbox/net-gateway-api 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 22, 2022

Hi @imjasonh. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, imjasonh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #339 (6af558f) into main (8b11425) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   16.55%   16.53%   -0.02%     
==========================================
  Files          21       21              
  Lines        3172     3175       +3     
==========================================
  Hits          525      525              
- Misses       2616     2619       +3     
  Partials       31       31              
Impacted Files Coverage Δ
test/conformance/gateway-api/path.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/percentage.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/visibility.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@knative-prow knative-prow bot merged commit b823557 into knative-extensions:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants