-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using knative.dev/pkg/pool, use errgroup instead #339
Stop using knative.dev/pkg/pool, use errgroup instead #339
Conversation
Welcome @imjasonh! It looks like this is your first PR to knative-sandbox/net-gateway-api 🎉 |
Hi @imjasonh. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, imjasonh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 16.55% 16.53% -0.02%
==========================================
Files 21 21
Lines 3172 3175 +3
==========================================
Hits 525 525
- Misses 2616 2619 +3
Partials 31 31
Help us with your feedback. Take ten seconds to tell us how you rate us. |
knative/pkg#2556
cc @dprotaso