-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envoy gateway testing #738
Add envoy gateway testing #738
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
170f3dc
to
621c2ba
Compare
/test integration-tests-envoy-gateway_net-gateway-api_main |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 79.12% 79.12%
=======================================
Files 17 17
Lines 1260 1260
=======================================
Hits 997 997
Misses 227 227
Partials 36 36 ☔ View full report in Codecov by Sentry. |
/test integration-tests-envoy-gateway_net-gateway-api_main |
31453e7
to
2b9d0de
Compare
/test integration-tests-envoy-gateway_net-gateway-api_main |
2b9d0de
to
eff3a5e
Compare
gateway isn't getting and addresss
|
* Users prefer setting their own custom names for generated k8s resources for the Envoy Proxy fleet instead of the autogenerated resources * https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319 * knative-extensions/net-gateway-api#738 * envoyproxy#2141 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
hey @dprotaso can we kick CI once, to see if this is a flake or something that just doesnt work in this setup ? setting the Gateway.Status.Addresses from the Svc is something that is verified in the conformance tests, so not sure why its not working here |
/retest
…On Mon, Jun 3, 2024 at 19:12 Arko Dasgupta ***@***.***> wrote:
hey @dprotaso <https://github.com/dprotaso> can we kick CI once, to see
if this is a flake or something that just doesnt work in this setup ?
setting the Gateway.Status.Addresses from the Svc is something that is
verified in the conformance tests, so not sure why its not working here
—
Reply to this email directly, view it on GitHub
<#738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAERAW6GUNWZMIB4S2A4F3ZFTZ7TAVCNFSM6AAAAABITNEBJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGI3TONRZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I also repro’d locally I don’t think it’s a fake - see the setup in the
third_party folder
On Mon, Jun 3, 2024 at 19:42 Dave Protasowski ***@***.***>
wrote:
… /retest
On Mon, Jun 3, 2024 at 19:12 Arko Dasgupta ***@***.***> wrote:
> hey @dprotaso <https://github.com/dprotaso> can we kick CI once, to see
> if this is a flake or something that just doesnt work in this setup ?
> setting the Gateway.Status.Addresses from the Svc is something that is
> verified in the conformance tests, so not sure why its not working here
>
> —
> Reply to this email directly, view it on GitHub
> <
#738 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAAERAW6GUNWZMIB4S2A4F3ZFTZ7TAVCNFSM6AAAAABITNEBJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGI3TONRZHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAERATTXZ7YO3PSCZPIH6TZFT5PRAVCNFSM6AAAAABITNEBJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWGMYDKOBQG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
* Users prefer setting their own custom names for generated k8s resources for the Envoy Proxy fleet instead of the autogenerated resources * https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319 * knative-extensions/net-gateway-api#738 * #2141 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
/test integration-tests-envoy-gateway_net-gateway-api_main |
3569e50
to
cfa1c09
Compare
/test integration-tests-envoy-gateway_net-gateway-api_main |
cfa1c09
to
0d57fe1
Compare
/test integration-tests-envoy-gateway_net-gateway-api_main I believe the failure is GKE related - similar to: #708 |
@arkodg all good now /assign @izabelacg |
Note we're testing the latest release - we'll want to pin it down when they release their next release |
/lgtm |
Part of #566