Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] gofmt go1.19 #1034

Merged
merged 1 commit into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/client/istio/clientset/versioned/fake/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions pkg/client/istio/clientset/versioned/scheme/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions pkg/reconciler/ingress/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ limitations under the License.
*/

/*
Package ingress implements a kubernetes controller which tracks Ingress resource
and reconcile VirtualService as its child resource.
*/
package ingress
2 changes: 2 additions & 0 deletions pkg/reconciler/ingress/ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@ func isIngressPublic(ing *v1alpha1.Ingress) bool {

// areVirtualServicesReady checks if *all* the provided virtual services have a status, and if so if it's ready.
// The return values are (hasStatus, ready), where:
//
// hasStatus indicates whether all the virtualServices have a status field
// ready indicates whether they all have been reconciled and are able to receive requests
func (r *Reconciler) areVirtualServicesReady(ctx context.Context, vses []*v1alpha3.VirtualService) (hasStatus, ready bool) {
Expand All @@ -547,6 +548,7 @@ func (r *Reconciler) areVirtualServicesReady(ctx context.Context, vses []*v1alph

// isVirtualServiceReady checks if a virtual service has a status, and if so if it's ready.
// The return values are (hasStatus, ready, err), where:
//
// hasStatus indicates whether the virtualService has a status field
// ready indicates whether it's been reconciled and able to receive requests
// err indicates an error occurred while looking up the status.
Expand Down
7 changes: 4 additions & 3 deletions pkg/reconciler/ingress/ingress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@ const (
)

// ingressfinalizer is the name that we put into the resource finalizer list, e.g.
// metadata:
// finalizers:
// - ingresses.networking.internal.knative.dev
//
// metadata:
// finalizers:
// - ingresses.networking.internal.knative.dev
var (
ingressResource = v1alpha1.Resource("ingresses")
ingressFinalizer = ingressResource.String()
Expand Down
1 change: 1 addition & 0 deletions test/e2e/clients.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package e2e

import (
Expand Down