fix: Fixed liveness periodseconds to 10 so that crashloopback off doe…

[mukulgit123]

Changes

Fixed liveness periodseconds to 10 so that crashloopback off doesn't happen which causes expired lease to get stuck.

Which is already fixed in knative-serving with knative/serving#15255

/kind bug

Fixes knative/serving#15255

Release Note

Docs

[knative-prow]

@mukulgit123: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

…sn't happen which causes expired lease to get stuck.

Changes

Fixed liveness periodseconds to 10 so that crashloopback off doesn't happen which causes expired lease to get stuck.

Which is already fixed in knative-serving with knative/serving#15255

/kind

Fixes knative/serving#15255

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

Welcome @mukulgit123! It looks like this is your first PR to knative-extensions/net-istio 🎉

[knative-prow]

Hi @mukulgit123. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ReToCode]

Hm probably introducing startup-probes is a better approach. This would also set the later lifeness-check to only every 10 seconds. This massively increases the time until the pod would be considered unhealthy: 10 * 6 = 60 seconds vs 10 * 1s.
WDYT @dprotaso @skonto ?

[dprotaso]

/lgtm
/approve

Hm probably introducing startup-probes is a better approach.

Want to do some follow up PRs? Let's merge this in for now.

[dprotaso]

/ok-to-test

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mukulgit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ReToCode]

@dprotaso no concerns about?

This massively increases the time until the pod would be considered unhealthy: 10 * 6 = 60 seconds vs 10 * 1s.

[dprotaso]

This massively increases the time until the pod would be considered unhealthy: 10 * 6 = 60 seconds vs 10 * 1s.

Unsure - because we've had now two scenarios in the past where the liveness kicks and restarts the pod before the webhook is ready.

Maybe our liveness probes are wrong and shouldn't be dependent on HTTPS.

This PR just fixes the stale lease issue - and we can make adjustments before v1.15 is out.