Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boilerplate #1342

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix boilerplate #1342

merged 1 commit into from
Jul 10, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jul 9, 2024

/assign @skonto

reported in #1341

@knative-prow knative-prow bot requested review from skonto and upodroid July 9, 2024 22:33
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2024
@dprotaso dprotaso mentioned this pull request Jul 9, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (a9ccc17) to head (295bc66).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1342   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          26       26           
  Lines        1668     1668           
=======================================
  Hits         1372     1372           
  Misses        195      195           
  Partials      101      101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ReToCode
ReToCode approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit dd16b76 into knative-extensions:main Jul 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@skonto skonto Awaiting requested review from skonto

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@skonto skonto

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @ReToCode @skonto