Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codegen to work outside GOPATH #158

Closed
wants to merge 1 commit into from
Closed

Update codegen to work outside GOPATH #158

wants to merge 1 commit into from

Conversation

Cynocracy
Copy link
Contributor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2020
@tcnghia
Copy link
Contributor

tcnghia commented Jul 17, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynocracy, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@Cynocracy Cynocracy closed this Aug 4, 2020
@Cynocracy Cynocracy reopened this Aug 4, 2020
@Cynocracy Cynocracy closed this Aug 5, 2020
@Cynocracy Cynocracy reopened this Aug 19, 2020
@Cynocracy Cynocracy closed this Aug 19, 2020
@knative-prow-robot
Copy link
Contributor

@Cynocracy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-net-istio-build-tests 6c8c543 link /test pull-knative-net-istio-build-tests
pull-knative-sandbox-net-istio-build-tests 6c8c543 link /test pull-knative-sandbox-net-istio-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chizhg chizhg Awaiting requested review from chizhg

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@tcnghia tcnghia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update-codegen.sh doesn't work outside GOPATH
4 participants
@Cynocracy @tcnghia @knative-prow-robot @googlebot