Implement RewriteHost #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
needs-rebase
The K-Network-Hash header will not match (or may not be present) if we redirect to an arbitrary host, so skip probing (which is best-effort anyway).
knative-prow-robot
removed
the
needs-rebase
|
let me know if this would be easier to review with the two commits split in to different PRs |
tcnghia
reviewed
Jul 16, 2020
|
/approve |
knative-prow-robot
added
the
approved
|
/assign @ZhiminXiang |
|
/lgtm /hold in case @ZhiminXiang has some comments |
knative-prow-robot
added
the
do-not-merge/hold
ZhiminXiang
reviewed
Jul 17, 2020
|
/lgtm |
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, tcnghia, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
The following is the coverage report on the affected files.
|
This was referenced Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of knative/serving#7748.
Note: it's not really sensible to try probing with a RewriteHost rule since we can't ensure the hash is what we expect, or even present (since it's returned by a different service), so this just skips probing if a RewriteHost rule is used.
Conformance test in serving: knative/serving#8592.
/assign @tcnghia @mattmoor