Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TLS 1.3 for min and max versions #1058

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Set TLS 1.3 for min and max versions #1058

merged 2 commits into from
Jun 6, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 6, 2023

This patch make a change that traffic from Kourier to Activator/QP uses TLS 1.3
when internal encryption is enabled.

Due to an issue of Envoy envoyproxy/envoy#9300,
we need to set TLS 1.3 for min and max version.

Part of knative/serving#14057

Release Note

Traffic from Kourier to Activator/QP uses TLS 1.3 when internal encryption is enabled.

/cc @dprotaso @skonto @ReToCode

@knative-prow knative-prow bot requested review from dprotaso, ReToCode and skonto June 6, 2023 02:59
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@nak3
Copy link
Contributor Author

nak3 commented Jun 6, 2023

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1058 (5936f1f) into main (3cd3437) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   80.94%   80.95%   +0.01%     
==========================================
  Files          18       18              
  Lines        1354     1355       +1     
==========================================
+ Hits         1096     1097       +1     
  Misses        205      205              
  Partials       53       53              
Impacted Files Coverage Δ
pkg/generator/ingress_translator.go 84.06% <100.00%> (+0.04%) ⬆️

@nak3 nak3 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 6, 2023
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@knative-prow knative-prow bot merged commit 5c2cb22 into knative-extensions:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants