Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventshub] Allow defining a custom response body for skipped events #358

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jul 6, 2022

This is needed for testing knative-extensions/eventing-kafka-broker#2374

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Changes

  • Allow defining a custom response body for skipped events

/kind enhancement

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2022
@pierDipi
Copy link
Member Author

pierDipi commented Jul 6, 2022

/cc @matzew @egorlepa

@knative-prow knative-prow bot requested a review from matzew July 6, 2022 10:14
@knative-prow
Copy link

knative-prow bot commented Jul 6, 2022

@pierDipi: GitHub didn't allow me to request PR reviews from the following users: egorlepa.

Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @matzew @egorlepa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cd61a92 into knative-extensions:main Jul 6, 2022
@matzew
Copy link
Contributor

matzew commented Aug 23, 2022

/cherry-pick release-1.6

@knative-prow-robot
Copy link

@matzew: new pull request created: #382

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants