Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get WebClient config from config map #149

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Get WebClient config from config map #149

merged 1 commit into from
Sep 7, 2020

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #141

Proposed Changes

  • 🎁 Now the webclient used by dispatcher can be configured using the config map config-kafka-broker-data-plane
  • 🧽 Some reorg of config file loading (maybe needs another pass in future)

Release Note

Now you can configure the web client options https://vertx-web-site.github.io/docs/apidocs/io/vertx/ext/web/client/WebClientOptions.html modifying the config map `config-kafka-broker-data-plane`

@slinkydeveloper
Get WebClient config from config map
df97796 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 7, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2020
pierDipi
pierDipi approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm

Would you mind opening an issue similar to the linked one for the HTTP server on the receiver side?

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020
@knative-prow-robot knative-prow-robot merged commit fa7b309 into knative-extensions:master Sep 7, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Sep 7, 2020
Closed
@slinkydeveloper slinkydeveloper deleted the issues/141 branch September 7, 2020 16:04
@pierDipi pierDipi mentioned this pull request Oct 1, 2020
Closed
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request Mar 17, 2022
@matzew
Merge pull request knative-extensions#149 from matzew/skip_gpg_1.1
e7367ac 
[release-v1.1] Skip GPG check for kubernetes repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract an env var to configure client idle timeout to the dispatcher
4 participants
@slinkydeveloper @knative-prow-robot @pierDipi @googlebot