-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose metrics defined by the spec in Prometheus format #244
Expose metrics defined by the spec in Prometheus format #244
Conversation
This PR exposes the following metrics: 1. http_events_sent_total 2. http_requests_produce_total 3. http_requests_malformed_total All of the above metrics are counters. (1) is incremented when the dispatcher commits the offset to Kafka. (2) is incremented when the receiver sends successfully the message to Kafka. (3) is incremented when the receiver receives a malformed event. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
============================================
- Coverage 76.40% 76.30% -0.11%
Complexity 170 170
============================================
Files 49 49
Lines 1420 1435 +15
Branches 46 46
============================================
+ Hits 1085 1095 +10
- Misses 266 271 +5
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nice trick reusing the other tests ;) |
…native-extensions#244) * Use PLAIN as default SASL if not specified Fixes knative-extensions#2117 * control plane test to default SASL PLAIN * Dedault to SASL PLAIN when doing connection not before * Added data-plane unit tests for defaulted SASL PLAIN * Reconcilation tests for Kafka source SASL Co-authored-by: Aleksander Slominski <aslom@us.ibm.com>
This PR exposes the following metrics:
All of the above metrics are counters.
(1) is incremented when the dispatcher commits the offset to Kafka.
(2) is incremented when the receiver sends successfully the message to Kafka.
(3) is incremented when the receiver receives a malformed event.
Signed-off-by Pierangelo Di Pilato pierangelodipilato@gmail.com
Fixes #227
Proposed Changes
Prometheus Dashboard
Release Note