-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a test based on the DeadLetterSinkGenericChannel feature #2957
Added a test based on the DeadLetterSinkGenericChannel feature #2957
Conversation
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Welcome @vishal-chdhry! It looks like this is your first PR to knative-sandbox/eventing-kafka-broker 🎉 |
Hi @vishal-chdhry. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test thanks for the PR @vishal-chdhry |
Codecov Report
@@ Coverage Diff @@
## main #2957 +/- ##
=============================================
- Coverage 81.25% 64.03% -17.22%
Complexity 754 754
=============================================
Files 77 155 +78
Lines 2619 10873 +8254
Branches 231 231
=============================================
+ Hits 2128 6963 +4835
- Misses 357 3411 +3054
- Partials 134 499 +365
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vishal-chdhry
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, Vishal-Chdhry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
Signed-off-by: Vishal Choudhary sendtovishalchoudhary@gmail.com
Fixes #2002
Proposed Changes
TestChannelDeadLetterSinkGenericChannel
Release Note
Docs