Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test based on the DeadLetterSinkGenericChannel feature #2957

Conversation

vishal-chdhry
Copy link
Contributor

Signed-off-by: Vishal Choudhary sendtovishalchoudhary@gmail.com

Fixes #2002

Proposed Changes

  • Adds a test
  • TestChannelDeadLetterSinkGenericChannel

Release Note

Added a test based on the DeadLetterSinkGenericChannel feature

Docs

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Feb 10, 2023

Welcome @vishal-chdhry! It looks like this is your first PR to knative-sandbox/eventing-kafka-broker 🎉

@knative-prow
Copy link

knative-prow bot commented Feb 10, 2023

Hi @vishal-chdhry. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test labels Feb 10, 2023
@matzew
Copy link
Contributor

matzew commented Feb 15, 2023

/ok-to-test

thanks for the PR @vishal-chdhry

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2957 (5042b79) into main (5475bd8) will decrease coverage by 17.22%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #2957       +/-   ##
=============================================
- Coverage     81.25%   64.03%   -17.22%     
  Complexity      754      754               
=============================================
  Files            77      155       +78     
  Lines          2619    10873     +8254     
  Branches        231      231               
=============================================
+ Hits           2128     6963     +4835     
- Misses          357     3411     +3054     
- Partials        134      499      +365     
Flag Coverage Δ
java-unittests 81.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 59.75% <0.00%> (ø)
control-plane/pkg/core/config/utils.go 79.61% <0.00%> (ø)
...-plane/pkg/reconciler/trigger/trigger_lifecycle.go 43.02% <0.00%> (ø)
...ntrol-plane/pkg/reconciler/trigger/v2/triggerv2.go 85.95% <0.00%> (ø)
control-plane/pkg/security/config.go 61.81% <0.00%> (ø)
...afka/eventing/v1alpha1/consumer_group_lifecycle.go 0.00% <0.00%> (ø)
control-plane/pkg/kafka/consumer_group_lag.go 62.59% <0.00%> (ø)
control-plane/pkg/apis/config/features.go 88.88% <0.00%> (ø)
control-plane/pkg/reconciler/consumergroup/auth.go 74.13% <0.00%> (ø)
...pkg/apis/eventing/v1alpha1/kafka_sink_lifecycle.go 73.33% <0.00%> (ø)
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pierDipi
Copy link
Member

/test unit-tests

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishal-chdhry

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, Vishal-Chdhry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@pierDipi
Copy link
Member

/retest-required

@knative-prow knative-prow bot merged commit 6ce03ba into knative-extensions:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test based on the DeadLetterSinkGenericChannel feature
3 participants