Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully clean up resources on shutdown #334

Merged
merged 5 commits into from
Nov 2, 2020
Merged

Gracefully clean up resources on shutdown #334

merged 5 commits into from
Nov 2, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 23, 2020 •
edited
Loading

Proposed Changes

  • Gracefully clean up resources on shutdown

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 23, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #334 into master will decrease coverage by 0.90%.
The diff coverage is 15.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #334      +/-   ##
============================================
- Coverage     76.27%   75.37%   -0.91%     
- Complexity      189      195       +6     
============================================
  Files            51       52       +1     
  Lines          1564     1600      +36     
  Branches         53       53              
============================================
+ Hits           1193     1206      +13     
- Misses          291      313      +22     
- Partials         80       81       +1
Flag Coverage Δ Complexity Δ
java-unittests 73.75% <15.47%> (-1.69%) 195.00 <7.00> (+6.00) ⬇️
unittests 75.37% <15.47%> (-0.91%) 195.00 <7.00> (+6.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...e/eventing/kafka/broker/core/file/FileWatcher.java 74.41% <0.00%> (-7.64%) 5.00 <1.00> (ø)
...knative/eventing/kafka/broker/dispatcher/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...v/knative/eventing/kafka/broker/receiver/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ive/eventing/kafka/broker/core/utils/Shutdown.java 72.22% <72.22%> (ø) 6.00 <6.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9c9e1...31a1364. Read the comment docs.

slinkydeveloper
slinkydeveloper approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@pierDipi
Copy link
Member Author

I'm fixing another thing.
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
@pierDipi pierDipi force-pushed the close-context-on-exception branch from 8cc4e1f to b85d692 Compare October 23, 2020 14:56
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2020
@pierDipi
Copy link
Member Author

/unhold
/cc slinkydeveloper

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
@pierDipi pierDipi changed the title Close Vertx when there is an exception Gracefully clean up resources on shutdown Oct 23, 2020
@pierDipi pierDipi changed the title Gracefully clean up resources on shutdown [WIP] Gracefully clean up resources on shutdown Oct 26, 2020
@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 26, 2020
@pierDipi pierDipi force-pushed the close-context-on-exception branch from b85d692 to 49288d3 Compare October 30, 2020 08:01
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2020
@pierDipi
Gracefully clean up resources on shutdown
445f82c 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the close-context-on-exception branch from 49288d3 to 445f82c Compare October 30, 2020 08:02
@pierDipi pierDipi changed the title [WIP] Gracefully clean up resources on shutdown Gracefully clean up resources on shutdown Oct 30, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2020
@pierDipi
Copy link
Member Author

Ready for a review.
/cc @slinkydeveloper

@pierDipi pierDipi force-pushed the close-context-on-exception branch from d1155e8 to af5e50b Compare October 30, 2020 08:57
@pierDipi
Extract commond logic into static methods
95ca75c 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the close-context-on-exception branch from af5e50b to 95ca75c Compare October 30, 2020 08:59
@pierDipi
Apply suggestion
bb6373d 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the close-context-on-exception branch from 82e56f6 to bb6373d Compare November 2, 2020 11:44
@pierDipi
Increase close timeout
92b8f2d 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Close vertx when there is an exception
31a1364 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pierDipi,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9a4f34d into knative-extensions:master Nov 2, 2020
@pierDipi pierDipi deleted the close-context-on-exception branch April 14, 2021 21:16
matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request Jul 14, 2022
@pierDipi
Self contained dockerfiles for images (knative-extensions#334)
b764b38 
In this patch, I'm removing the requirement to build binaries
on the host and then build the image by copying the binary.

This improves consistency because the build isn't different
based on the environment is built.
In addition, this simplifies my openshift/release reconciler.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

Assignees

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @slinkydeveloper @knative-prow-robot