Implement Trigger.Spec.DeliverySpec #612

pierDipi · 2021-02-09T07:34:47Z

Fixes #578

I'd wait for an E2E test from the eventing repository.

Proposed Changes

Implement Trigger.Spec.DeliverySpec

Release Note

:gift: Add support for Trigger.Spec.DeliverySpec

/kind enhancement

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

codecov · 2021-02-09T07:37:37Z

Codecov Report

Merging #612 (1ce0449) into master (1b4152a) will decrease coverage by 0.15%.
The diff coverage is 69.44%.

@@             Coverage Diff              @@
##             master     #612      +/-   ##
============================================
- Coverage     72.40%   72.24%   -0.16%     
  Complexity      396      396              
============================================
  Files            72       72              
  Lines          2674     2684      +10     
  Branches        115      116       +1     
============================================
+ Hits           1936     1939       +3     
- Misses          596      599       +3     
- Partials        142      146       +4

Flag	Coverage Δ	Complexity Δ
java-unittests	`79.45% <28.57%> (-0.17%)`	`0.00 <2.00> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
.../core/reconciler/impl/ResourcesReconcilerImpl.java	`93.15% <0.00%> (-0.65%)`	`58.00 <0.00> (ø)`
...r/dispatcher/http/HttpConsumerVerticleFactory.java	`85.13% <33.33%> (-2.37%)`	`26.00 <2.00> (ø)`
control-plane/pkg/reconciler/trigger/trigger.go	`70.96% <50.00%> (-0.70%)`	`0.00 <0.00> (ø)`
control-plane/pkg/core/config/utils.go	`74.46% <77.77%> (+2.05%)`	`0.00 <0.00> (ø)`
control-plane/pkg/reconciler/broker/broker.go	`78.07% <100.00%> (-0.64%)`	`0.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4152a...a9a6a18. Read the comment docs.

knative-metrics-robot · 2021-02-09T07:37:52Z

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
control-plane/pkg/core/config/utils.go	89.5%	88.9%	-0.6
control-plane/pkg/reconciler/broker/broker.go	87.9%	87.3%	-0.6
control-plane/pkg/reconciler/trigger/trigger.go	85.6%	85.1%	-0.4

slinkydeveloper

Not much of a difference for us, unhold at your will

slinkydeveloper · 2021-02-09T08:01:52Z

/hold

pierDipi · 2021-02-09T10:07:56Z

It needs lgtm tho.
/unhold

slinkydeveloper · 2021-02-10T13:53:13Z

/lgtm
/approve

knative-prow-robot · 2021-02-10T13:53:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierDipi,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2021-02-10T15:23:20Z

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

pierDipi · 2021-02-10T16:19:17Z

A PR in eventing broke a test knative/eventing#4843

pierDipi · 2021-02-10T16:27:10Z

This should fix it #627

pierDipi · 2021-02-10T17:55:54Z

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

slinkydeveloper · 2021-02-10T18:50:13Z

/retest

* Add EgressConfig to Egress Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Generate protobuf code Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Controller saves Trigger.Spec.Delivery in contract Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Use EgressConfig of Egress and fallback to Resource.EgressConfig Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Improve delivery parsing error messages Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Use matav1 as import name of apimachinery/pkg/apis/meta/v1 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Change error messages in broker tests Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

pierDipi added 7 commits February 9, 2021 08:17

Add EgressConfig to Egress

291636d

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Generate protobuf code

7b8d744

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Controller saves Trigger.Spec.Delivery in contract

a9d3aed

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Use EgressConfig of Egress and fallback to Resource.EgressConfig

12023b5

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Improve delivery parsing error messages

8a97bd8

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Use matav1 as import name of apimachinery/pkg/apis/meta/v1

245faea

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Change error messages in broker tests

a9a6a18

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

knative-prow-robot added kind/enhancement area/control-plane labels Feb 9, 2021

knative-prow-robot requested review from matzew and slinkydeveloper February 9, 2021 07:34

knative-prow-robot added area/data-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2021

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 9, 2021

knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 9, 2021

slinkydeveloper approved these changes Feb 9, 2021

View reviewed changes

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021

pierDipi requested a review from slinkydeveloper February 9, 2021 10:22

knative-prow-robot assigned slinkydeveloper Feb 10, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021

knative-prow-robot merged commit 33fc401 into knative-extensions:master Feb 10, 2021

pierDipi deleted the KNATIVE-578 branch April 14, 2021 21:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Trigger.Spec.DeliverySpec #612

Implement Trigger.Spec.DeliverySpec #612

pierDipi commented Feb 9, 2021

codecov bot commented Feb 9, 2021 •

edited

Loading

knative-metrics-robot commented Feb 9, 2021

slinkydeveloper left a comment •

edited

Loading

slinkydeveloper commented Feb 9, 2021

pierDipi commented Feb 9, 2021

slinkydeveloper commented Feb 10, 2021

knative-prow-robot commented Feb 10, 2021

pierDipi commented Feb 10, 2021

pierDipi commented Feb 10, 2021 •

edited

Loading

pierDipi commented Feb 10, 2021

pierDipi commented Feb 10, 2021

slinkydeveloper commented Feb 10, 2021

Implement Trigger.Spec.DeliverySpec #612

Implement Trigger.Spec.DeliverySpec #612

Conversation

pierDipi commented Feb 9, 2021

Proposed Changes

codecov bot commented Feb 9, 2021 • edited Loading

Codecov Report

knative-metrics-robot commented Feb 9, 2021

slinkydeveloper left a comment • edited Loading

Choose a reason for hiding this comment

slinkydeveloper commented Feb 9, 2021

pierDipi commented Feb 9, 2021

slinkydeveloper commented Feb 10, 2021

knative-prow-robot commented Feb 10, 2021

pierDipi commented Feb 10, 2021

pierDipi commented Feb 10, 2021 • edited Loading

pierDipi commented Feb 10, 2021

pierDipi commented Feb 10, 2021

slinkydeveloper commented Feb 10, 2021

codecov bot commented Feb 9, 2021 •

edited

Loading

slinkydeveloper left a comment •

edited

Loading

pierDipi commented Feb 10, 2021 •

edited

Loading