Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SASL mechanism PLAIN #840

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

pierDipi
Copy link
Member

Fixes #794

Strimzi doesn't support this, so we can't test this E2E :(

Proposed Changes

  • Support SASL mechanism PLAIN
Support SASL mechanism PLAIN.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi requested review from a team as code owners April 24, 2021 10:04
@pierDipi pierDipi requested a review from a user April 24, 2021 10:04
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 24, 2021
@knative-prow-robot knative-prow-robot added area/control-plane area/data-plane size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2021
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #840 (d9fd4fd) into main (c809ce3) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #840      +/-   ##
============================================
- Coverage     76.57%   76.53%   -0.04%     
  Complexity      440      440              
============================================
  Files            77       77              
  Lines          2924     2924              
  Branches        133      133              
============================================
- Hits           2239     2238       -1     
- Misses          534      535       +1     
  Partials        151      151              
Flag Coverage Δ Complexity Δ
java-unittests 80.20% <100.00%> (-0.06%) 440.00 <4.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
control-plane/pkg/security/config.go 53.33% <ø> (ø) 0.00 <0.00> (ø)
...fka/broker/core/security/CredentialsValidator.java 93.93% <100.00%> (ø) 23.00 <4.00> (+1.00)
...dispatcher/consumer/impl/BaseConsumerVerticle.java 90.00% <0.00%> (-3.34%) 8.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c809ce3...d9fd4fd. Read the comment docs.

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Apr 26, 2021

@pierDipi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-sandbox-eventing-kafka-broker-go-coverage d9fd4fd link /test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member Author

/test pull-knative-sandbox-eventing-kafka-broker-unit-tests

@knative-prow-robot knative-prow-robot merged commit 8b31f2e into knative-extensions:main Apr 26, 2021
@pierDipi
Copy link
Member Author

/cherry-pick release-0.22

@knative-prow-robot
Copy link
Contributor

@pierDipi: #840 failed to apply on top of branch "release-0.22":

Applying: Support SASL mechanism PLAIN
Using index info to reconstruct a base tree...
M	data-plane/THIRD-PARTY.txt
Falling back to patching base and 3-way merge...
Auto-merging data-plane/THIRD-PARTY.txt
CONFLICT (content): Merge conflict in data-plane/THIRD-PARTY.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Support SASL mechanism PLAIN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 1, 2021
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 1, 2021
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot pushed a commit that referenced this pull request May 4, 2021
* fix: Allow SASLMechanism to equal "PLAIN" (#855)

* Support SASL mechanism PLAIN (#840)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Antoine Cotten <hello@acotten.com>
knative-prow-robot pushed a commit that referenced this pull request May 31, 2021
* Support SASL mechanism PLAIN (#840)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* fix: Allow SASLMechanism to equal "PLAIN" (#855)

* Remove --strict flag

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Co-authored-by: Antoine Cotten <hello@acotten.com>
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative supports the SASL mechanisms PLAIN in the document, but actually not.
3 participants