-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SASL mechanism PLAIN #840
Support SASL mechanism PLAIN #840
Conversation
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
============================================
- Coverage 76.57% 76.53% -0.04%
Complexity 440 440
============================================
Files 77 77
Lines 2924 2924
Branches 133 133
============================================
- Hits 2239 2238 -1
- Misses 534 535 +1
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pierDipi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-knative-sandbox-eventing-kafka-broker-unit-tests |
/cherry-pick release-0.22 |
@pierDipi: #840 failed to apply on top of branch "release-0.22":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
…s is the default now anyhow (knative-extensions#840)
Fixes #794
Strimzi doesn't support this, so we can't test this E2E :(
Proposed Changes