Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multiple receiver verticles #985

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jun 13, 2021

As of today our receiver deployment doesn't use more than 1 CPU.

This patch deploys multiple receiver verticle based on the number of CPUs
available.

Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com

Release Note

Receiver deployment uses all available CPUs.

As of today our receiver deployment doesn't use more than 1 CPU.

This patch deploys multiple receiver verticle based on the number of CPUs
available.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot added area/data-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 13, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2021
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #985 (21e4a13) into main (3ec1fab) will increase coverage by 0.11%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #985      +/-   ##
============================================
+ Coverage     75.60%   75.72%   +0.11%     
- Complexity      417      421       +4     
============================================
  Files            73       74       +1     
  Lines          2906     2916      +10     
  Branches        124      124              
============================================
+ Hits           2197     2208      +11     
  Misses          556      556              
+ Partials        153      152       -1     
Flag Coverage Δ
java-unittests 79.63% <44.44%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...v/knative/eventing/kafka/broker/receiver/Main.java 0.00% <0.00%> (ø)
...kafka/broker/receiver/ReceiverVerticleFactory.java 57.14% <57.14%> (ø)
...ting/kafka/broker/dispatcher/RecordDispatcher.java 93.33% <0.00%> (+2.22%) ⬆️
...dispatcher/consumer/impl/BaseConsumerVerticle.java 93.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec1fab...21e4a13. Read the comment docs.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit dbfbf4b into knative-extensions:main Jun 16, 2021
slinkydeveloper pushed a commit to slinkydeveloper/eventing-kafka-broker that referenced this pull request Jun 18, 2021
* Create multiple receiver verticles

As of today our receiver deployment doesn't use more than 1 CPU.

This patch deploys multiple receiver verticle based on the number of CPUs
available.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Rename supplier to factory

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants