-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create multiple receiver verticles #985
Create multiple receiver verticles #985
Conversation
As of today our receiver deployment doesn't use more than 1 CPU. This patch deploys multiple receiver verticle based on the number of CPUs available. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #985 +/- ##
============================================
+ Coverage 75.60% 75.72% +0.11%
- Complexity 417 421 +4
============================================
Files 73 74 +1
Lines 2906 2916 +10
Branches 124 124
============================================
+ Hits 2197 2208 +11
Misses 556 556
+ Partials 153 152 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...eiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/ReceiverVerticleSupplier.java
Outdated
Show resolved
Hide resolved
data-plane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/Main.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Create multiple receiver verticles As of today our receiver deployment doesn't use more than 1 CPU. This patch deploys multiple receiver verticle based on the number of CPUs available. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Rename supplier to factory Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
As of today our receiver deployment doesn't use more than 1 CPU.
This patch deploys multiple receiver verticle based on the number of CPUs
available.
Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com
Release Note