-
Notifications
You must be signed in to change notification settings - Fork 83
reduce apiserver requests for dispatcher #456
reduce apiserver requests for dispatcher #456
Conversation
Signed-off-by: XinYang <xinydev@gmail.com>
Welcome @xinydev! It looks like this is your first PR to knative-sandbox/eventing-kafka 🎉 |
Hi @xinydev. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 73.94% 73.80% -0.14%
==========================================
Files 138 138
Lines 5315 5315
==========================================
- Hits 3930 3923 -7
- Misses 1140 1145 +5
- Partials 245 247 +2
Continue to review full report at Codecov.
|
looks like a good change (thanks!) - I'm doing a quick smoke test now and then will approve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix - nice efficiency win !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: travis-minke-sap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
…ons#462) Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
…ons#463) Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Signed-off-by: XinYang xinydev@gmail.com
The dispatcher now only gets information for the channel it cares about. reducing the GET requests to apiserver in a cluster with lots of channels.
Proposed Changes
Release Note
Docs