Fix typo / copy pasta in example Pipeline #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We renamed `inputSourceBindings` (and `outputSourceBindings`) to `resources` in tektoncd#148 where we also moved the specification of these bindings into the `PipelineRun` - now the `resources` section in the `Pipeline` itself exists just to specify dependencies between resources. But we missed one in the example! Also created tektoncd#297 to follow up on catching this in validation.
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We renamed
inputSourceBindings(andoutputSourceBindings) toresourcesin #148 where we also moved the specification of thesebindings into the
PipelineRun- now theresourcessection in thePipelineitself exists just to specify dependencies between resources.But we missed one in the example!
Also created #297 to follow up on catching this in validation.
(Thanks for pointing this out @bkuschel!! ❤️ )