Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify for golang only doing hack #1619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify for golang only doing hack #1619

wants to merge 1 commit into from
+1 −1

Conversation

matzew
Copy link
Member

@matzew matzew commented Oct 1, 2024

Changes

  • based on discussion it feels that hack setup is useful for golang only - hence updating the template

/kind

Fixes #

Release Note

Docs

@matzew
Clarify for golang only doing hack
830a5bd 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 1, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • based on discussion it feels that hack setup is useful for golang only - hence updating the template

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2024
@dsimansk
Copy link
Contributor

dsimansk commented Oct 1, 2024

/approve
/lgtm

/hold for Dave

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@dprotaso
Copy link
Member

dprotaso commented Oct 4, 2024

technically it's for anything - but the default ones are golang

you just need to include a bash function in your scripts to override it

eg. https://github.com/knative/hack/blob/fc6a8452af6d002ab7fb2818520a6f3d105ee1a0/presubmit-tests.sh#L179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @dsimansk @dprotaso