Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust memberships #1661

Merged
merged 2 commits into from
Jan 28, 2025
Merged

adjust memberships #1661

merged 2 commits into from
Jan 28, 2025

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 27, 2025 •
edited
Loading

Post submit jobs failed for #1659

groups - https://prow.knative.dev/view/gs/knative-prow/logs/post-knativeteam-groups/1883895909339631616
peribolos - https://prow.knative.dev/view/gs/knative-prow/logs/post-knative-peribolos/1883895909410934784

Fixes:

  • add the right user account 'thelinuxfoundation'
  • can't make a group ('steering') an owner of a group ('wg-leads')

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2025
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2025
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2025
@dprotaso
Copy link
Member Author

/assign @aliok

cc @knative/steering-committee

aliok
aliok approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1b3b515 into knative:main Jan 28, 2025
7 checks passed
@aliok
Copy link
Member

aliok commented Jan 28, 2025 •
edited
Loading

Still fails:

2025/01/28 07:41:49 unable to add steering@knative.team to "calendar-maintainers@knative.team" as OWNER: googleapi: Error 400: Invalid Input: memberKey, invalid

To be fixed by #1662

@aliok aliok mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

@nrrso nrrso Awaiting requested review from nrrso

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @aliok @knative-prow-robot