Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eventing-XXX to repo config for sandbox #261

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Add eventing-XXX to repo config for sandbox #261

merged 2 commits into from
Sep 10, 2020

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Sep 3, 2020 •
edited
Loading

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 3, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2020
@lionelvillard
Copy link
Member Author

/assign @evankanderson

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2020
@lionelvillard lionelvillard changed the title Add eventing-github to repo config for sandbox Add eventing-XXX to repo config for sandbox Sep 8, 2020
@slinkydeveloper
Copy link
Contributor

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020
@lionelvillard
Copy link
Member Author

/unhold

I fixed it.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020
@evankanderson
Copy link
Member

/lgtm
/approve

Things seem to be alphabetical, the names match the tickets, and all the names are in all the places.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@knative-prow-robot knative-prow-robot merged commit ebf14dc into knative:master Sep 10, 2020
chaodaiG pushed a commit to chaodaiG/community that referenced this pull request Sep 15, 2020
@zqzzq
add zqzzq (knative#261)
0f80626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper left review comments

@pierDipi pierDipi pierDipi requested changes

@grantr grantr Awaiting requested review from grantr

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lionelvillard @slinkydeveloper @evankanderson @knative-prow-robot @pierDipi @googlebot