Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate WG membership and technical process documentation to the TOC #73

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

evankanderson
Copy link
Member

I'd been meaning to send this for a while, but it was way too annoying to look up the OWNERS file syntax. I believe that this will still allow the steering committee to approve WG leads changes as well as changes in mechanics, but will delegate day-to-day approvals in these files to the TOC.

/assign @rgregg
/assign @pmorie
/assign @bsnchan

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 30, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evankanderson: 1 invalid OWNERS file

In response to this:

I'd been meaning to send this for a while, but it was way too annoying to look up the OWNERS file syntax. I believe that this will still allow the steering committee to approve WG leads changes as well as changes in mechanics, but will delegate day-to-day approvals in these files to the TOC.

/assign @rgregg
/assign @pmorie
/assign @bsnchan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OWNERS Outdated Show resolved Hide resolved
@evankanderson
Copy link
Member Author

/hold

It turns out that filters don't work with prow OWNERS suggestions (if I understand the bug correctly): kubernetes/test-infra#7690

Should we move WORKING-GROUPS.md into mechanics/ (and leave a symlink) to separate things out more clearly?

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 30, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 6, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 6, 2020
@evankanderson
Copy link
Member Author

This is now adding only an OWNERS file for mechanics/, where we've been keeping recommended WG process documents. It also relies on hierarchical OWNERS files to prefer to send the PRs to the TOC -- Steering will still be able to approve changes in these directories, but shouldn't need to be involved in the day-to-day.

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@evankanderson
Copy link
Member Author

/assign @pmorie

@pmorie
Copy link
Member

pmorie commented Apr 14, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@rgregg
Copy link
Contributor

rgregg commented Apr 14, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@rgregg rgregg added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2020
@knative-prow-robot knative-prow-robot merged commit 29028fd into knative:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants