Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skonto in sandbox #978

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Add skonto in sandbox #978

merged 2 commits into from
Mar 30, 2022

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Mar 24, 2022

Add myself as a member in knative-sandbox and as approver for net-{istio, kourier} to help with new features review for example encryption work.

/cc @nak3 @rhuss

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skonto
To complete the pull request process, please assign thisisnotapril after the PR has been reviewed.
You can assign the PR to them by writing /assign @thisisnotapril in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Contributor

rhuss commented Mar 24, 2022

/approve
/lgtm

@evankanderson
Copy link
Member

/assign @itsmurugappan

(Since we need someone from Steering for the top-level OWNERS_ALIASES changes)

@itsmurugappan
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@knative-prow
Copy link

knative-prow bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, rhuss, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@knative-prow knative-prow bot merged commit d71f165 into knative:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants