Skip to content

Commit

Permalink
Add a note on replication factor value (#3348)
Browse files Browse the repository at this point in the history
* Add a note on replication factor value

We've got a bug [1] report for a misconfiguration of
`default.topic.replication.factor`.
This PR adds a note that could alert users on the
value of this configuration.

[1] knative-extensions/eventing-kafka-broker#720

* Update docs/eventing/broker/kafka-broker.md

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>

Co-authored-by: Ashleigh Brennan <40172997+abrennan89@users.noreply.github.com>
  • Loading branch information
pierDipi and abrennan89 authored Mar 15, 2021
1 parent 807a80b commit bcc0d7e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/eventing/broker/kafka-broker.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ The above `ConfigMap` is installed in the cluster. You can edit
the configuration or create a new one with the same values
depending on your needs.

**NOTE:** The `default.topic.replication.factor` value must be less than or equal to the number of Kafka broker instances in your cluster. For example, if you only have one Kafka broker, the `default.topic.replication.factor` value should not be more than `1`.

## Set as default broker implementation

To set the Kafka broker as the default implementation for all brokers in the Knative deployment,
Expand Down

0 comments on commit bcc0d7e

Please sign in to comment.