Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for max-scale global setting #2736

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add documentation for max-scale global setting #2736

merged 2 commits into from
Aug 10, 2020

Conversation

arturenault
Copy link
Contributor

Proposed Changes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 10, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2020
markusthoemmes
markusthoemmes reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit. Thanks!

docs/serving/autoscaling/scale-bounds.md Outdated Show resolved Hide resolved
@markusthoemmes
Update docs/serving/autoscaling/scale-bounds.md
a78b2ea 
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
@abrennan89
Copy link
Contributor

/lgtm
/approve

Thanks for the update @arturenault 👍

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, arturenault

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a4e1991 into knative:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@abrennan89 abrennan89

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arturenault @abrennan89 @knative-prow-robot @markusthoemmes @googlebot