Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the feature/extension flags. #2791

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Document the feature/extension flags. #2791

merged 1 commit into from
Sep 1, 2020
+200 −0

Conversation

JRBANCEL
Copy link
Contributor

@JRBANCEL JRBANCEL commented Sep 1, 2020

Fixes #2782

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 1, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2020
@JRBANCEL
Copy link
Contributor Author

JRBANCEL commented Sep 1, 2020

/assign @mattmoor

@JRBANCEL JRBANCEL mentioned this pull request Sep 1, 2020
Closed
mattmoor
mattmoor reviewed Sep 1, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JRBANCEL this looks like a great start for us to iterate on.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JRBANCEL, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member

mattmoor commented Sep 1, 2020

/hold
/assign @abrennan89

Let's give Ashleigh a crack at this.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@knative-prow-robot knative-prow-robot merged commit 66da56f into knative:master Sep 1, 2020
@mattmoor
Copy link
Member

mattmoor commented Sep 1, 2020

Apparently I type too slow :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@mattmoor mattmoor

@abrennan89 abrennan89

Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page documenting Serving feature flags
5 participants
@JRBANCEL @knative-prow-robot @mattmoor @googlebot @abrennan89