Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance DLQ CloudEvents with destination #4228

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Enhance DLQ CloudEvents with destination #4228

merged 1 commit into from
Sep 16, 2021

Conversation

travis-minke-sap
Copy link
Contributor

@travis-minke-sap travis-minke-sap commented Sep 13, 2021 •
edited
Loading

These changes are related to Eventing Issue #5726 (PR #5727).

Simply attempting to add a new CloudEvent extension attribute to Dead Letter Sink events capturing the original destination URL.

Proposed Changes

  • Enhancing the current documentation by describing the new knativeerrordest extension attribute in the same manner as existing attributes.

Holding until the actual Eventing PR is merged ; )
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 13, 2021
@netlify
Copy link

netlify bot commented Sep 13, 2021 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 5112146

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/613fa303598394000777b649

😎 Browse the preview: https://deploy-preview-4228--knative.netlify.app/development/developer/eventing/event-delivery

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2021
@knative-prow-robot
Copy link
Contributor

Hi @travis-minke-sap. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travis-minke-sap travis-minke-sap mentioned this pull request Sep 13, 2021
Merged
5 tasks
@lionelvillard
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2021
@matzew
Copy link
Member

matzew commented Sep 15, 2021

/lgtm

now we just need the feature to be merged!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@travis-minke-sap
Copy link
Contributor Author

The related Issue #5727 was merged so this should be good to merge as well. I think it just needs to be "approved"?

The mkdocs strict check that is failing appears to be for unrelated files. I don't know if I should concern myself with this or not???

WARNING  -  Documentation file 'admin/install/installing-istio.md' contains a link to 'serving/getting-started-knative-app.md' which is not found in the documentation files.
WARNING  -  Redirect target 'docs/getting-started/README.md' does not exist!
WARNING  -  Redirect target 'docs/getting-started/README.md' does not exist!

Aborted with 3 warnings in strict mode!
Error: Process completed with exit code 1.

@travis-minke-sap
Copy link
Contributor Author

/retest

abrennan89
abrennan89 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, travis-minke-sap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@abrennan89 abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@abrennan89
Copy link
Contributor

/retest

@knative-prow-robot knative-prow-robot merged commit fef19d0 into knative:main Sep 16, 2021
@travis-minke-sap travis-minke-sap deleted the enhance-dlq-cloudevents-with-dest branch September 16, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrennan89 abrennan89 abrennan89 approved these changes

Assignees

@matzew matzew

@abrennan89 abrennan89

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@travis-minke-sap @knative-prow-robot @lionelvillard @matzew @abrennan89