DeliverySpec.RetryAfter Experimental-Feature #4361
Conversation
knative-prow-robot
added
the
do-not-merge/hold
|
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: a974489 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61a675ee0f1fda0007c572ce 😎 Browse the preview: https://deploy-preview-4361--knative.netlify.app/development/eventing/experimental-features |
knative-prow-robot
added
the
size/M
|
This is ready for review @snneji if you want to take a look |
|
@travis-minke-sap you don't need to put a hold for review, when something is in hold means we are going to ignore it and assume the PR submitter is still working on changes to be submitted and not ready yet /unhold |
knative-prow-robot
removed
the
do-not-merge/hold
Thanks for the great review @snneji - much appreciated - I've made the suggested changes. |
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
|
I added the hold label back as I see the issue knative/eventing#5811 hasn't closed yet, although it seems that PR knative/eventing#5813 related to that issue has been merged. You can unhold again if it's ready. /lgtm |
knative-prow-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: snneji, travis-minke-sap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, the intent is for the Issue to remain open during the lifecycle of the "experimental-feature" and the important thing is that the initial development work is in place. Thanks again! /unhold |
knative-prow-robot
removed
the
do-not-merge/hold
This change id based on eventing Issue #5811 for which the initial implementation has been merged.
Proposed Changes
Ready for review now that the initial Retry-After implementation has been merged!