Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to set Kafka Topic config options #5854

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Feb 7, 2024

This documents how to set Kafka topic config options on a broker.

Proposed Changes

  • Add a paragraph explaining that we support all kafka topic config options, and how to set them

Note: this should not merge until after knative-extensions/eventing-kafka-broker#3671

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3127b35
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65c53197aa5d7c000826c1d8
😎 Deploy Preview https://deploy-preview-5854--knative.netlify.app/docs/eventing/brokers/broker-types/kafka-broker
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 7, 2024
@knative-prow knative-prow bot requested review from pierDipi and pmbanugo February 7, 2024 19:14
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Feb 7, 2024

@knative-prow knative-prow bot requested review from Leo6Leo and matzew February 7, 2024 19:14
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Feb 8, 2024

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi February 8, 2024 19:55
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
Copy link

knative-prow bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member Author

Cali0707 commented Feb 9, 2024

/unhold
The feature is merged now

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@knative-prow knative-prow bot merged commit 090349a into knative:main Feb 9, 2024
19 checks passed
@Cali0707
Copy link
Member Author

Cali0707 commented Feb 9, 2024

/cherry-pick release-1.13
/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #5859

In response to this:

/cherry-pick release-1.13
/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Member Author

Cali0707 commented Feb 9, 2024

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #5860

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
* doc: documented how to set topic config

Signed-off-by: Calum Murray <cmurray@redhat.com>

* doc: add link to allowed kafka topic config options

Signed-off-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants