Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap website colours of the Home page #6029

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

ShravaniAK
Copy link
Contributor

@ShravaniAK ShravaniAK commented Jun 26, 2024

Fixes #6028

Proposed Changes

  • swapped the main 2 primary light and primary dark colours
  • changed the nav-item-color to #494848
  • added consistent corner rounding and spacing between buttons.

Signed-off-by: SHRAVANI KAWARE <97099574+ShravaniAK@users.noreply.github.com>
@knative-prow knative-prow bot requested a review from ReToCode June 26, 2024 15:32
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 92f338e
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/667ce87728926a000887a7d3
😎 Deploy Preview https://deploy-preview-6029--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@ShravaniAK
Copy link
Contributor Author

/cc @Cali0707 @aliok

@knative-prow knative-prow bot requested review from aliok and Cali0707 June 26, 2024 15:35
@Cali0707
Copy link
Member

/hold until UX WG approves colour changes
/cc @mmejia02 @zainabhusain227
do these new colours match the design system or should we change them at all?

@knative-prow knative-prow bot requested a review from mmejia02 June 26, 2024 16:11
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@mmejia02
Copy link

mmejia02 commented Jul 1, 2024

@ShravaniAK, these are already really great changes!! It looks like you got all of the hex codes right, but weirdly it seems to be rendering the dark blue much lighter than it should. I'm unsure how to solve that problem. As you know, the dark blue hex code is #0D4984, which you have in your sourcecode. However, if you put the pre-release side by side, you see this dark blue is much lighter.
image
Also it would be great if the text colour on the first block of the homescreen were black/the off black colour we've been using. The light blue and greys look great!! Thank you for all of your work!

@ShravaniAK
Copy link
Contributor Author

@mmejia02 thankyou very much for your feedback , the dark blue color problem is not there in my browser and also i checked with the latest deploy preview link , also I have already replaced the text color of first container of homescreen with black color , do you want be to replace it with some different shade of black ?

Screenshot 2024-07-01 at 4 56 42 PM

@mmejia02
Copy link

mmejia02 commented Jul 1, 2024

@ShravaniAK , in your browser it looks amazing and I have no other feedback!! Exciting stuff :) I still have no idea why my rendering is being weird but it's fine

@Cali0707
Copy link
Member

Cali0707 commented Jul 2, 2024

Okay let's merge this for now, and then @ShravaniAK can you try testing this on some other browsers?

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm
/approve

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
Copy link

knative-prow bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@knative-prow knative-prow bot merged commit 9407dfa into knative:main Jul 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap website colours to be in line with logo and to meet WCAG AAA
4 participants