Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Mark TriggerMesh as Defunct #6154

Closed

Conversation

zacheryph
Copy link

@zacheryph zacheryph commented Oct 31, 2024

Proposed Changes

  • Marks All TriggerMesh Eventing Sources as Defunct.

Sadly Triggermesh shuttered a year ago, last fall. It is sad to see them gone, though these probably should not be marked as active anymore.

I wonder if these should simply be removed or possibly add a 3rd section for.. Historic? Defunct? not sure what to name it 🤔

Reference: triggermesh/triggermesh#1544 (comment)

Copy link

knative-prow bot commented Oct 31, 2024

Welcome @zacheryph! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2024
Copy link

knative-prow bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zacheryph
Once this PR has been reviewed and has the lgtm label, please assign nainaz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4a04d9e
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/673c9cdac913850008850323
😎 Deploy Preview https://deploy-preview-6154--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierDipi
Copy link
Member

pierDipi commented Nov 5, 2024

I wonder if these should simply be removed or possibly add a 3rd section for.. Historic? Defunct? not sure what to name it

Thanks @zacheryph, I would remove them.

In the meantime, we're working on replacements and we would love feedback on which one you would be using here: knative/eventing#8185

@zacheryph zacheryph force-pushed the update-triggermesh-classification branch from 7335a7c to 4a04d9e Compare November 19, 2024 14:12
@zacheryph
Copy link
Author

@pierDipi apologize, I missed notification for this one. Updated to remove Triggermesh. I will have to take a look at that issue.

@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@zacheryph
Copy link
Author

So much for that...

@zacheryph zacheryph closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants