Skip to content

Conversation

qswinson
Copy link
Contributor

@qswinson qswinson commented Sep 5, 2025

Adds documentation for PR AWS MSK IAM Authentication

Proposed Changes

This documents the configuration necessary to use AWS MSK IAM authentication for Kafka eventing.

Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ae96fd
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68e6a1679944bc0008634fd9
😎 Deploy Preview https://deploy-preview-6365--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

linux-foundation-easycla bot commented Sep 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Sep 5, 2025

Welcome @qswinson! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot requested review from creydr and pierDipi September 5, 2025 21:40
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2025
Comment on lines 273 to 278
- config-kafka-broker-data-plane
- config-kafka-broker-producer.properties
- config-kafka-broker-consumer.properties
- config-kafka-channel-data-plane
- config-kafka-channel-producer.properties
- config-kafka-channel-consumer.properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't render the way you wanted

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-10-08 at 11 40 03 fixed formatting

@dprotaso
Copy link
Member

dprotaso commented Sep 8, 2025

Going to hold this PR until the changes in EKB repo land

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2025
@dprotaso
Copy link
Member

dprotaso commented Sep 8, 2025

/easycla

@evankanderson
Copy link
Member

Sorry about the merge -- in #6398 , I moved all the versioned documentation under versioned, to separate it from the blog, testimonials, community pages that are not version-specific. You should be able to just move these files to the new location; I didn't need to change any contents.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025
@dprotaso
Copy link
Member

dprotaso commented Oct 8, 2025

/ok-to-test

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 8, 2025
@dprotaso
Copy link
Member

dprotaso commented Oct 8, 2025

/hold cancel - given the feature has merged

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2025
@qswinson qswinson requested a review from dprotaso October 8, 2025 17:40
@dprotaso
Copy link
Member

dprotaso commented Oct 8, 2025

/lgtm
/approve

thanks @qswinson 🎉

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
Copy link

knative-prow bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, qswinson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@knative-prow knative-prow bot merged commit a3deff6 into knative:main Oct 8, 2025
19 checks passed
@qswinson qswinson deleted the aws-msk-iam branch October 8, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants