Skip to content

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 8, 2025

No description provided.

Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit a1a4779
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68e69e3c0d79130008fa2c8e
😎 Deploy Preview https://deploy-preview-6435--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@knative-prow knative-prow bot requested review from creydr and nainaz October 8, 2025 17:24
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Oct 8, 2025

/assign @Cali0707 @creydr @matzew
/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/assign @Cali0707 @creydr @matzew
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

![Image](images/image21.png)

The code for the sample app is in `docs/code-samples/eventing/bookstore-sample-app`
The code for the sample app is in `docs/versioned/code-samples/eventing/bookstore-sample-app`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slipped in - but we still want it anyways

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
Copy link

knative-prow bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 50d55e3 into knative:main Oct 8, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6436

In response to this:

/assign @Cali0707 @creydr @matzew
/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants