Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Nov 13, 2025

Proposed Changes

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e10c6a
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/6915b60f9d144c0008463677
😎 Deploy Preview https://deploy-preview-6500--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and nainaz November 13, 2025 10:42
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2025
@creydr creydr marked this pull request as ready for review November 13, 2025 10:46
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@creydr
Copy link
Member Author

creydr commented Nov 13, 2025

/cc @gauron99 @lkingland

@knative-prow knative-prow bot requested review from gauron99 and lkingland November 13, 2025 10:46
@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@knative-prow knative-prow bot merged commit be7dbc5 into knative:main Nov 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants