Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

[WIP] Kafka channel fix scope #1191

Closed
wants to merge 2 commits into from

Conversation

aliok
Copy link
Member

@aliok aliok commented May 5, 2020

Fixes #1189

Proposed Changes

Release Note


Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 5, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
To complete the pull request process, please assign matzew
You can assign the PR to them by writing /assign @matzew in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot requested review from lberk and matzew May 5, 2020 12:12
@aliok
Copy link
Member Author

aliok commented May 5, 2020

I wanted to create this PR for fixing #1189 but as per the comment #1189 (comment), I will close.

@aliok aliok closed this May 5, 2020
@knative-prow-robot
Copy link
Contributor

@aliok: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-contrib-unit-tests b40202e link /test pull-knative-eventing-contrib-unit-tests
pull-knative-eventing-contrib-build-tests b40202e link /test pull-knative-eventing-contrib-build-tests
pull-knative-eventing-contrib-integration-tests b40202e link /test pull-knative-eventing-contrib-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaChannel doesn't respect the scope annotation when creating the topic
3 participants