Skip to content

Add ability to override jwks_url #6982

Add ability to override jwks_url

Add ability to override jwks_url #6982

Re-run triggered December 16, 2024 06:56
Status Failure
Total duration 3m 43s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
2s
style / changes
style  /  ...  /  Auto-format and Check
16s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
3m 21s
style / Golang / Lint
style  /  ...  /  Do Not Submit
5s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
18s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 7 warnings
style / Golang / Auto-format and Check: pkg/apis/feature/features_test.go#L1
Please run goimports. diff --git a/pkg/apis/feature/features_test.go b/pkg/apis/feature/features_test.go index 2dfb341..902dac0 100644 --- a/pkg/apis/feature/features_test.go +++ b/pkg/apis/feature/features_test.go @@ -63,7 +63,7 @@ func TestGetFlags(t *testing.T) { require.Equal(t, expectedNodeSelector, nodeSelector) require.Equal(t, flags.OIDCDiscoveryBaseURL(), "https://oidc.eks.eu-west-1.amazonaws.com/id/1") - + require.Equal(t, flags.JWKSURI(), "https://oidc.eks.eu-west-1.amazonaws.com/id/1/jwk") }
style / Golang / Auto-format and Check: pkg/apis/feature/flag_names.go#L1
Please run goimports. diff --git a/pkg/apis/feature/flag_names.go b/pkg/apis/feature/flag_names.go index 3103114..ee8c470 100644 --- a/pkg/apis/feature/flag_names.go +++ b/pkg/apis/feature/flag_names.go @@ -30,5 +30,5 @@ const ( AuthorizationDefaultMode = "default-authorization-mode" OIDCDiscoveryBaseURL = "oidc-discovery-base-url" RequestReplyDefaultTimeout = "requestreply-default-timeout" - JWKSURI = "oidc-jwks-uri" + JWKSURI = "oidc-jwks-uri" )
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / changes
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / Golang / Do Not Submit
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / suggester / yaml
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum