-
Notifications
You must be signed in to change notification settings - Fork 600
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* added basic template for trigger dlq tests + removed duplicated import * added file for trigger sink related tests * modified DLQ for DLS for proper use of terminology + added test where the trigger DLS is use instead of its corresponding broker one * added test cases for triggers dls * changed tab for spaces on comments * fixed descriptions on tests * added part where test makes sure no events are been sent to brokers DLS * added test for broker nil uri in triggers broker DLS resolving fallback * fixed comment * fixed pr comments * changed copyright year for new trigger test rekt e2e file * fixing typo * fixing pr comments * fixed incorect test setup description * added functions necesary for build brokers with dls as precondition + changed broker and trigger tests structure for them to use the needed preconditions * fixed name of aux test function * Update test/rekt/features/trigger/trigger_sink_resolution.go Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Update test/rekt/features/trigger/trigger_sink_resolution.go Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
- Loading branch information
Showing
7 changed files
with
273 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| /* | ||
| Copyright 2021 The Knative Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package trigger | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "knative.dev/eventing/test/rekt/resources/broker" | ||
| "knative.dev/eventing/test/rekt/resources/delivery" | ||
| "knative.dev/eventing/test/rekt/resources/eventlibrary" | ||
| "knative.dev/eventing/test/rekt/resources/trigger" | ||
| "knative.dev/reconciler-test/pkg/eventshub" | ||
| "knative.dev/reconciler-test/pkg/feature" | ||
| ) | ||
|
|
||
| // SourceToTriggerSinkWithDLS tests to see if a Ready Trigger with a DLS defined send | ||
| // failing events to it's DLS. | ||
| // | ||
| // source ---> broker --[trigger]--> bad uri | ||
| // | | ||
| // +--[DLS]--> sink | ||
| // | ||
| func SourceToTriggerSinkWithDLS(triggerName, brokerName string, prober *eventshub.EventProber) *feature.Feature { | ||
| prober.SetTargetResource(broker.GVR(), brokerName) | ||
| f := feature.NewFeature() | ||
|
|
||
| lib := feature.MakeRandomK8sName("lib") | ||
| f.Setup("install events", eventlibrary.Install(lib)) | ||
| f.Setup("event cache is ready", eventlibrary.IsReady(lib)) | ||
| f.Setup("use events cache", prober.SenderEventsFromSVC(lib, "events/three.ce")) | ||
| if err := prober.ExpectYAMLEvents(eventlibrary.PathFor("events/three.ce")); err != nil { | ||
| panic(fmt.Errorf("can not find event files: %s", err)) | ||
| } | ||
|
|
||
| // Setup Probes | ||
| f.Setup("install recorder", prober.ReceiverInstall("sink")) | ||
|
|
||
| // Setup trigger | ||
| f.Setup("install trigger", trigger.Install( | ||
| triggerName, | ||
| brokerName, | ||
| trigger.WithSubscriber(nil, "bad://uri"), | ||
| delivery.WithDeadLetterSink(prober.AsKReference("sink"), ""))) | ||
|
|
||
| // Resources ready. | ||
| f.Setup("trigger goes ready", trigger.IsReady(triggerName)) | ||
|
|
||
| // Install sender. | ||
| f.Setup("install source", prober.SenderInstall("source")) | ||
|
|
||
| // After we have finished sending. | ||
| f.Requirement("sender is finished", prober.SenderDone("source")) | ||
|
|
||
| // Assert events ended up where we expected. | ||
| f.Stable("trigger with DLS"). | ||
| Must("accepted all events", prober.AssertSentAll("source")). | ||
| Must("deliver event to DLS", prober.AssertReceivedAll("source", "sink")) | ||
|
|
||
| return f | ||
| } | ||
|
|
||
| // SourceToTriggerSinkWithDLSDontUseBrokers tests to see if a Ready Trigger sends | ||
| // failing events to it's DLS even when it's corresponding Ready Broker also have a DLS defined. | ||
| // | ||
| // source ---> broker --[trigger]--> bad uri | ||
| // | | | ||
| // +--[DLS] +--[DLS]--> sink | ||
| // | ||
| func SourceToTriggerSinkWithDLSDontUseBrokers(triggerName, brokerName, brokerSinkName string, prober *eventshub.EventProber) *feature.Feature { | ||
| triggerSinkName := "trigger-sink" | ||
| prober.SetTargetResource(broker.GVR(), brokerName) | ||
|
|
||
| f := feature.NewFeature() | ||
|
|
||
| lib := feature.MakeRandomK8sName("lib") | ||
| f.Setup("install events", eventlibrary.Install(lib)) | ||
| f.Setup("event cache is ready", eventlibrary.IsReady(lib)) | ||
| f.Setup("use events cache", prober.SenderEventsFromSVC(lib, "events/three.ce")) | ||
| if err := prober.ExpectYAMLEvents(eventlibrary.PathFor("events/three.ce")); err != nil { | ||
| panic(fmt.Errorf("can not find event files: %s", err)) | ||
| } | ||
|
|
||
| // Setup Probes | ||
| f.Setup("install trigger recorder", prober.ReceiverInstall(triggerSinkName)) | ||
| f.Setup("install brokers recorder", prober.ReceiverInstall(brokerSinkName)) | ||
|
|
||
| // Setup topology | ||
| brokerConfig := append( | ||
| broker.WithEnvConfig(), | ||
| delivery.WithDeadLetterSink(prober.AsKReference(brokerSinkName), "")) | ||
| f.Setup("install broker with DLS", broker.Install( | ||
| brokerName, | ||
| brokerConfig..., | ||
| )) | ||
|
|
||
| f.Setup("install trigger", trigger.Install( | ||
| triggerName, | ||
| brokerName, | ||
| trigger.WithSubscriber(nil, "bad://uri"), | ||
| delivery.WithDeadLetterSink(prober.AsKReference(triggerSinkName), ""))) | ||
|
|
||
| // Resources ready. | ||
| f.Setup("trigger goes ready", trigger.IsReady(triggerName)) | ||
|
|
||
| // Install events after topology is ready. | ||
| f.Setup("install source", prober.SenderInstall("source")) | ||
|
|
||
| // After we have finished sending. | ||
| f.Requirement("sender is finished", prober.SenderDone("source")) | ||
|
|
||
| // Assert events ended up where we expected. | ||
| f.Stable("trigger with a valid DLS ref"). | ||
| Must("accept all events", prober.AssertSentAll("source")). | ||
| Must("deliver events to trigger DLS", prober.AssertReceivedAll("source", triggerSinkName)). | ||
| Must("not deliver events to its broker DLS", noEventsToDLS(prober, brokerSinkName)) | ||
|
|
||
| return f | ||
| } | ||
|
|
||
| func noEventsToDLS(prober *eventshub.EventProber, sinkName string) feature.StepFn { | ||
| return func(ctx context.Context, t feature.T) { | ||
| if len(prober.ReceivedBy(ctx, sinkName)) == 0 { | ||
| t.Log("no events were sent to %s DLS", sinkName) | ||
| } else { | ||
| t.Errorf("events were received by %s DLS", sinkName) | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.