Skip to content

Commit

Permalink
Don't restrict namespace for perf test objects (#1983)
Browse files Browse the repository at this point in the history
The RBAC rules for config read need to be created in a different
namespace, so we can't restrict the namespace here or kubectl will error
out.
  • Loading branch information
grantr authored and knative-prow-robot committed Oct 1, 2019
1 parent 0545676 commit 6d3bfb7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/performance/tools/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function delete_benchmark_resources() {

echo ">> Delete all existing jobs and test resources"
kubectl delete job --all
ko delete -n ${TEST_NAMESPACE} -f "${TEST_ROOT_PATH}/${name}/${variant}/" || abort "Failed to delete ${name}/${variant} resources"
ko delete -f "${TEST_ROOT_PATH}/${name}/${variant}/" || abort "Failed to delete ${name}/${variant} resources"
}

# Apply all the benchmark resources
Expand All @@ -135,7 +135,7 @@ function apply_benchmark_resources() {
# NOTE: this assumes we have a benchmark with the same name as the cluster
# If service creation takes long time, we will have some initially unreachable errors in the test
echo "Using ko version $(ko version)"
ko apply -n ${TEST_NAMESPACE} -f "$TEST_ROOT_PATH/$name/${variant}/" || abort "Failed to apply ${name}/${variant} benchmark yamls"
ko apply -f "$TEST_ROOT_PATH/$name/${variant}/" || abort "Failed to apply ${name}/${variant} benchmark yamls"
}

# Update resources installed on the cluster with the up-to-date code. This
Expand Down

0 comments on commit 6d3bfb7

Please sign in to comment.