remove reconciled normal event from subscriptions (#3695)

knative · Jul 23, 2020 · b93138b · b93138b
1 parent e83e316
commit b93138b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/pkg/reconciler/subscription/subscription.go b/pkg/reconciler/subscription/subscription.go
@@ -62,10 +62,6 @@ var (
 	v1ChannelGVK      = v1.SchemeGroupVersion.WithKind("Channel")
 )
 
-func newReconciledNormal(namespace, name string) pkgreconciler.Event {
-	return pkgreconciler.NewEvent(corev1.EventTypeNormal, "SubscriptionReconciled", "Subscription reconciled: \"%s/%s\"", namespace, name)
-}
-
 func newChannelWarnEvent(messageFmt string, args ...interface{}) pkgreconciler.Event {
 	return pkgreconciler.NewEvent(corev1.EventTypeWarning, channelReferenceFailed, messageFmt, args...)
 }
@@ -117,7 +113,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, subscription *v1beta1.Su
 		return event
 	}
 
-	return newReconciledNormal(subscription.Namespace, subscription.Name)
+	return nil
 }
 
 func (r *Reconciler) FinalizeKind(ctx context.Context, subscription *v1beta1.Subscription) pkgreconciler.Event {

diff --git a/pkg/reconciler/subscription/subscription_test.go b/pkg/reconciler/subscription/subscription_test.go
@@ -208,9 +208,6 @@ func TestAllCases(t *testing.T) {
 			},
 			Key:     testNS + "/" + subscriptionName,
 			WantErr: false,
-			WantEvents: []string{
-				Eventf(corev1.EventTypeNormal, "SubscriptionReconciled", `Subscription reconciled: "testnamespace/testsubscription"`),
-			},
 			WantStatusUpdates: []clientgotesting.UpdateActionImpl{{
 				Object: NewSubscription(subscriptionName, testNS,
 					WithSubscriptionUID(subscriptionUID),