Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test - Tracing through CronJobSource #1769

Closed
Harwayne opened this issue Aug 29, 2019 · 4 comments
Closed

E2E Test - Tracing through CronJobSource #1769

Harwayne opened this issue Aug 29, 2019 · 4 comments
Labels
area/observability good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone

Comments

@Harwayne
Copy link
Contributor

This should not be started until after #1758 is closed.

Problem
In order to ensure that CronJobSource generates traces correctly, we need an E2E test.

Persona:
Contributor

Exit Criteria
A test in the e2e suite that runs before every PR merge. The test verifies that an event sent from a CronJobSource sent to something that doesn't emit traces (e.g. a simple web server) still creates a trace with a span for the communication between CronJobSource and its sink.

@Harwayne
Copy link
Contributor Author

/project Observability To do

@knative-prow-robot
Copy link
Contributor

@n3wscott:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

similar to https://github.com/knative/eventing/blob/master/test/conformance/broker_tracing_test.go and https://github.com/knative/eventing/blob/master/test/conformance/channel_tracing_test.go.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 20, 2020
@grantr grantr added this to the Backlog milestone Aug 24, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants