Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance testing for Channel URL #1958

Closed
aslom opened this issue Sep 24, 2019 · 4 comments
Closed

Conformance testing for Channel URL #1958

aslom opened this issue Sep 24, 2019 · 4 comments
Labels

Comments

@aslom
Copy link
Member

aslom commented Sep 24, 2019

Problem
From channel specification extracted testable
“The HTTP event queueing request's URL MUST correspond to a single, unique
Channel at any given moment in time. This MAY be done via the host, path, query
string, or any combination of these. This mapping is handled exclusively by the
Channel implementation, exposed via the Channel's status.address. If an HTTP
event queueing request's URL does not correspond to an existing Channel, then
the Channel MUST respond with 404 Not Found.

Persona:
Which persona is this feature for?

System Integrator, Contributors

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Test runs without errors for in-memory channel

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

1h?

Additional context (optional)
Add any other context about the feature request here.

@aslom
Copy link
Member Author

aslom commented Sep 24, 2019

Testable enough by checking status.address is URL and modify URL with random changes to verify 404?

@Harwayne
Copy link
Contributor

/project Channels To do

@akashrv akashrv added this to the v0.12.0 milestone Oct 3, 2019
@akashrv akashrv added area/channels area/test-and-release Test infrastructure, tests or release labels Dec 10, 2019
@akashrv akashrv modified the milestones: v0.12.0, v0.13.0 Feb 12, 2020
@lionelvillard lionelvillard removed this from the v0.13.0 milestone Mar 3, 2020
@aliok
Copy link
Member

aliok commented Jun 22, 2020

/close

We're good in terms of this test.

Closing this ticket as:

  • we already check if there's a URL reported 1
  • the URL is already checked for validity 2 3
  • it is not possible to modify URL with random changes to verify 404 because the current Channel implementations only use subdomains for uniqueness, not URL params etc.

@knative-prow-robot
Copy link
Contributor

@aliok: Closing this issue.

In response to this:

/close

We're good in terms of this test.

Closing this ticket as:

  • we already check if there's a URL reported 1
  • the URL is already checked for validity 2 3
  • it is not possible to modify URL with random changes to verify 404 because the current Channel implementations only use subdomains for uniqueness, not URL params etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants