Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests for channel status requirements #2992

Closed
2 tasks
aliok opened this issue Apr 15, 2020 · 2 comments · Fixed by #3000
Closed
2 tasks

Conformance tests for channel status requirements #2992

aliok opened this issue Apr 15, 2020 · 2 comments · Fixed by #3000
Assignees
@aliok
Labels
area/channels area/test-and-release Test infrastructure, tests or release kind/feature-request

Comments

@aliok
Copy link
Member

aliok commented Apr 15, 2020 •
edited
Loading

Problem

Following tasks are created according to the spec.

Tests:

  • v1alpha1: When the channel instance is ready to receive events status.address.hostname and status.address.url MUST be populated and status.addressable MUST be set to True.
  • v1beta1: When the channel instance is ready to receive events status.address.url MUST be populated and status.addressable MUST be set to True.

Note: As there's no way of knowing what channel spec version the channel supports, instantiate a channel and then check the annotation messaging.knative.dev/subscribable in the channel instance . There's more info for this in #2987.

Persona:
System Integrator, Contributors

Exit Criteria
Test required behavior of channel, maybe report on optional capabilities.

Time Estimate (optional):
1d
@aliok aliok mentioned this issue Apr 15, 2020
Closed
4 tasks
@aliok
Copy link
Member Author

aliok commented Apr 16, 2020

/area channels
/area test-and-release

@knative-prow-robot knative-prow-robot added area/channels area/test-and-release Test infrastructure, tests or release labels Apr 16, 2020
@aliok
Copy link
Member Author

aliok commented Apr 16, 2020

/assign @aliok

@aliok aliok mentioned this issue Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliok aliok

Labels
area/channels area/test-and-release Test infrastructure, tests or release kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Status conformance tests for channels aliok/eventing
2 participants
@aliok @knative-prow-robot