Conformance tests for channel annotation requirements

[aliok]

Problem

Extracting from the spec:

Annotation Requirements
Each instantiated Channel (ie, Custom Object) SHOULD have an annotation indicating which version of the Channelable duck type it conforms to. We currently have two versions:
v1alpha1
v1beta1
So, for example to indicate that the Channel supports v1beta1 duck type, you should annotate it like so (only showing the annotations):

- apiVersion: messaging.knative.dev/v1beta1
  kind: YourChannelType
  metadata:
    annotations: 
      messaging.knative.dev/subscribable: v1beta1

Unfortunately, we had to make breaking changes between the two versions, and to ensure functionality, the channel implementer must indicate which version they support. To ensure backwards compatibility with old channels, if no annotation is given, we assume it's v1alpha1.

Tests:

• Instantiated channel should have messaging.knative.dev/subscribable annotation with value v1alpha1 or v1beta1

Persona:
System Integrator, Contributors

Exit Criteria
Test required behavior of channel, maybe report on optional capabilities.

Time Estimate (optional):
1d

[aliok]

/project Channels

[knative-prow-robot]

@aliok: You must be a member of the knative/eventing github team to set the project and column.

In response to this:

/project Channels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matzew]

/project Channels

[knative-prow-robot]

@matzew: You must be a member of the knative/eventing github team to set the project and column.

In response to this:

/project Channels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aliok]

/assign @aliok

[aliok]

/In Progress

[aliok]

/Project In Progress

[aliok]

/area channels
/area test-and-release

[aliok]

Unless there's a way of checking what channel duck type version the channel supports without creating an instance of the channel, this test doesn't make sense.

Say it supports v1alpha1 channel duck type. The annotation value will be either empty or v1alpha1.

Say it supports v1beta1 channel duck type. The annotation value will be v1beta1.

But, we can only find out the channel duck type version the channel supports using the annotation. So, it will be like testing the value against itself.

I asked the in the channel if there's any other way: https://knative.slack.com/archives/C9JP909F0/p1587021907420500

/close

[knative-prow-robot]

@aliok: Closing this issue.

In response to this:

Unless there's a way of checking what channel duck type version the channel supports without creating an instance of the channel, this test doesn't make sense.

Say it supports v1alpha1 channel duck type. The annotation value will be either empty or v1alpha1.

Say it supports v1beta1 channel duck type. The annotation value will be v1beta1.

But, we can only find out the channel duck type version the channel supports using the annotation. So, it will be like testing the value against itself.

I asked the in the channel if there's any other way: https://knative.slack.com/archives/C9JP909F0/p1587021907420500

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.