Conformance tests for channel CRD spec requirements

[aliok]

Problem

Extracting from the spec:

Spec Requirements
v1alpha1 Spec: each channel CRD MUST contain an array of subscribers: spec.subscribable.subscribers
v1beta1 Spec: each channel CRD MUST contain an array of subscribers: spec.subscribers

Tests:

• Channel CRD MUST have spec.subscribable.subscribers or spec.subscribers. As there's no way of knowing what channel spec version the channel supports, instantiate a channel and then check the annotation messaging.knative.dev/subscribable in the channel instance . There's more info for this in Conformance tests for channel annotation requirements #2987.

Persona:
System Integrator, Contributors

Exit Criteria
Test required behavior of channel, maybe report on optional capabilities.

Time Estimate (optional):
2d

[aliok]

/area channels
/area test-and-release

[aliok]

/close

This test does not make a lot of sense.
Similar to #2989 (comment)

[knative-prow-robot]

@aliok: Closing this issue.

In response to this:

/close

This test does not make a lot of sense.
Similar to #2989 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aliok]

/reopen

No, it makes sense. We cannot create CRs with random fiels; the fields should be configured. Webhook is configured that way and we can test it.

[knative-prow-robot]

@aliok: Reopened this issue.

In response to this:

/reopen

No, it makes sense

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matzew]

With a v1beta1 and v1alpha Channel (backed by IMC) I get nothing in the spec, for the channel. but for the actual IMC

spec:
  subscribers:
  - delivery:
      deadLetterSink: {}
    generation: 2
    subscriberUri: http://channel-display0.default.svc.cluster.local
    uid: 7e233c04-e250-478e-b9e8-8575157beb83

[matzew]

the spec.subscribers is updated by the subscription

[aliok]

I added the conformance tests in #3050 but there's some things that are not compliant. Created #3051 for that.