Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible for Flows to use Bus or ClusterBus #336

Closed
pmorie opened this issue Aug 9, 2018 · 2 comments
Closed

Make it possible for Flows to use Bus or ClusterBus #336

pmorie opened this issue Aug 9, 2018 · 2 comments

Comments

@pmorie
Copy link
Member

pmorie commented Aug 9, 2018

Currently, the Flow type doesn't contain API surface to allow a user to specify the bus or cluster bus that should be used for the channels created for the flow. We should add this to FlowSpec and consider having an admission controller that sets a default value rather than relying on the controller opaquely choosing a ClusterBus.
@pmorie pmorie mentioned this issue Aug 9, 2018
Merged
@n3wscott
Copy link
Contributor

/close

flow is old model

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closing this issue.

In response to this:

/close

flow is old model

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pmorie @n3wscott @knative-prow-robot