Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apis.HTTP() instead of apis.ParseURL() in the codebase #3623

Closed
capri-xiyue opened this issue Jul 17, 2020 · 8 comments · Fixed by #3830
Closed

Use apis.HTTP() instead of apis.ParseURL() in the codebase #3623

capri-xiyue opened this issue Jul 17, 2020 · 8 comments · Fixed by #3830
Assignees
@skonto
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Backlog

Comments

@capri-xiyue
Copy link
Contributor

Problem
In the codebase, we use apis.ParseURL() in a lot of places. As @aliok suggested, #3616 (comment), apis.HTTP() is more convenient. We can use apis.HTTP() instead of apis.ParseURL() in the codebase

Persona:
Which persona is this feature for?

Exit Criteria
Use apis.HTTP() instead of apis.ParseURL() in the codebase

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.
@capri-xiyue capri-xiyue mentioned this issue Jul 17, 2020
Merged
@capri-xiyue
Copy link
Contributor Author

This is a good-first-issue

@pierDipi
Copy link
Member

/good-first-issue

@knative-prow-robot
Copy link
Contributor

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 17, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 23, 2020

Luckily not too many files ;)

pkg/apis/flows/v1/parallel_lifecycle_test.go
pkg/apis/flows/v1/sequence_lifecycle_test.go
pkg/apis/flows/v1beta1/parallel_lifecycle_test.go
pkg/apis/flows/v1beta1/sequence_lifecycle_test.go
pkg/apis/sources/v1alpha1/apiserver_conversion_test.go
pkg/apis/sources/v1alpha1/apiserver_lifecycle.go
pkg/apis/sources/v1alpha1/ping_conversion_test.go
pkg/apis/sources/v1alpha1/ping_lifecycle_test.go
pkg/apis/sources/v1alpha1/sinkbinding_conversion_test.go
pkg/apis/sources/v1alpha2/apiserver_conversion_test.go
pkg/apis/sources/v1alpha2/apiserver_lifecycle_test.go
pkg/apis/sources/v1alpha2/container_conversion_test.go
pkg/apis/sources/v1alpha2/ping_lifecycle_test.go
pkg/apis/sources/v1beta1/apiserver_lifecycle_test.go
pkg/inmemorychannel/message_dispatcher_test.go
pkg/mtbroker/filter/filter_handler_test.go
pkg/reconciler/apiserversource/apiserversource_test.go
pkg/reconciler/mtbroker/broker_test.go
pkg/reconciler/pingsource/pingsource_test.go
pkg/reconciler/pingsource/resources/receive_adapter_test.go
pkg/reconciler/source/duck/duck.go
pkg/reconciler/source/duck/duck_test.go
pkg/reconciler/testing/v1/trigger.go
pkg/reconciler/testing/v1beta1/trigger.go
test/conformance/helpers/channel_spec_test_helper.go
test/lib/resources/eventing.go

@lberk lberk added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 27, 2020
@lberk lberk added this to the Backlog milestone Jul 27, 2020
@lberk lberk added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 27, 2020
@skonto
Copy link
Contributor

skonto commented Aug 11, 2020

I can do that could you assign me to it.

@pierDipi
Copy link
Member

pierDipi commented Aug 11, 2020 •
edited
Loading

@skonto You can comment with /assign

@lionelvillard
Copy link
Member

/assign @skonto

@skonto
Copy link
Contributor

skonto commented Aug 12, 2020 •
edited
Loading

updated list:

$grep -Ril "apis.ParseURL" ./ | wc -l
29
$ grep -Ril "apis.ParseURL" ./ | sort
./pkg/apis/flows/v1beta1/parallel_lifecycle_test.go
./pkg/apis/flows/v1beta1/sequence_lifecycle_test.go
./pkg/apis/flows/v1/parallel_lifecycle_test.go
./pkg/apis/flows/v1/sequence_lifecycle_test.go
./pkg/apis/sources/v1alpha1/apiserver_conversion_test.go
./pkg/apis/sources/v1alpha1/apiserver_lifecycle.go
./pkg/apis/sources/v1alpha1/ping_conversion_test.go
./pkg/apis/sources/v1alpha1/ping_lifecycle_test.go
./pkg/apis/sources/v1alpha1/sinkbinding_conversion_test.go
./pkg/apis/sources/v1alpha2/apiserver_conversion_test.go
./pkg/apis/sources/v1alpha2/apiserver_lifecycle_test.go
./pkg/apis/sources/v1alpha2/container_conversion_test.go
./pkg/apis/sources/v1alpha2/ping_conversion_test.go
./pkg/apis/sources/v1alpha2/ping_lifecycle_test.go
./pkg/apis/sources/v1beta1/apiserver_lifecycle_test.go
./pkg/apis/sources/v1beta1/ping_lifecycle_test.go
./pkg/inmemorychannel/message_dispatcher_test.go
./pkg/mtbroker/filter/filter_handler_test.go
./pkg/reconciler/apiserversource/apiserversource_test.go
./pkg/reconciler/mtbroker/broker_test.go
./pkg/reconciler/mtbroker/trigger/trigger_test.go
./pkg/reconciler/pingsource/pingsource_test.go
./pkg/reconciler/pingsource/resources/receive_adapter_test.go
./pkg/reconciler/source/duck/duck.go
./pkg/reconciler/source/duck/duck_test.go
./pkg/reconciler/testing/v1beta1/trigger.go
./pkg/reconciler/testing/v1/trigger.go
./test/conformance/helpers/channel_spec_test_helper.go
./test/lib/resources/eventing.go

@skonto skonto mentioned this issue Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skonto skonto

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Use apis.HTTP() skonto/eventing
7 participants
@lberk @lionelvillard @skonto @vaikas @pierDipi @knative-prow-robot @capri-xiyue