Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] API for subscriptions.messaging.knative.dev is v1 #4931

Closed
7 tasks done
n3wscott opened this issue Feb 22, 2021 · 2 comments · Fixed by #5361
Closed
7 tasks done

[1.0] API for subscriptions.messaging.knative.dev is v1 #4931

n3wscott opened this issue Feb 22, 2021 · 2 comments · Fixed by #5361
Assignees
@n3wscott
Milestone
Backlog

Comments

@n3wscott
Copy link
Contributor

n3wscott commented Feb 22, 2021 •
edited
Loading

The following work needs to be validated for subscriptions.messaging.knative.dev to be ready for 1.0:

  • subscriptions.messaging.knative.dev is served v1 by default
  • Previous served versions are deprecated and removed according to the Knative API process.
  • v1 OpenAPI schema in CRD is complete.
  • subscriptions.messaging.knative.dev has a validating webhook with 100% coverage according to its spec.
    • for creation
    • for mutation
  • subscriptions.messaging.knative.dev has a defaulting webhook with 100% coverage according to its spec.
@lberk lberk added this to the Backlog milestone Mar 1, 2021
@slinkydeveloper slinkydeveloper added kind/good-first-issue Denotes an issue ready for a new contributor. and removed kind/good-first-issue Denotes an issue ready for a new contributor. labels Mar 10, 2021
@aliok aliok mentioned this issue Apr 26, 2021
Merged
5 tasks
@n3wscott
Copy link
Contributor Author

n3wscott commented May 6, 2021

/assign

@n3wscott n3wscott mentioned this issue May 7, 2021
Merged
@n3wscott
Copy link
Contributor Author

n3wscott commented May 7, 2021

Fixed by #4931

@n3wscott n3wscott closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n3wscott n3wscott

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Subscription resource API validation. n3wscott/eventing
3 participants
@lberk @slinkydeveloper @n3wscott