WIP: add configmap for flow controller #240
Conversation
google-prow-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pmorie If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
size/M
|
@pmorie: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -43,6 +44,7 @@ import ( | |||
| // TODO: Get rid of these, but needed as other controllers use them. | |||
| servingclientset "github.com/knative/serving/pkg/client/clientset/versioned" | |||
| servinginformers "github.com/knative/serving/pkg/client/informers/externalversions" | |||
| servingconfigmaps "github.com/knative/serving/pkg/configmap" | |||
There was a problem hiding this comment.
I'm totally fine for using this from the serving stack for now, but we should pull this into a common place so we don't have to take a dependency between repos. Perhaps add a TODO here and file an issue in Serving to move this out to some common repo.
| @@ -170,6 +186,9 @@ func NewController( | |||
| }, | |||
| }) | |||
|
|
|||
| // TODO: const for knative-system | |||
| controller.controllerConfigMapWatcher = servingconfigmaps.NewDefaultWatcher(kubeclientset, "knative-system") | |||
There was a problem hiding this comment.
should this be knative-eventing?
There was a problem hiding this comment.
also think there's a way to get the eventing namespace... time passes... yeah, pkg/names.go
There was a problem hiding this comment.
use system.Namespace for now.
| @@ -184,6 +203,9 @@ func (c *Controller) Run(threadiness int, stopCh <-chan struct{}) error { | |||
| // Start the informer factories to begin populating the informer caches | |||
| glog.Info("Starting Flow controller") | |||
|
|
|||
| glog.Info("Watching controller config") | |||
| c.controllerConfigMapWatcher.Watch("flow-controller-config", c.receiveControllerConfig) | |||
There was a problem hiding this comment.
maybe hoist this into the const?
|
oh yeah I want this! |
|
/assign @n3wscott |
|
Need to reopen this due to now-private fork |
🤖 Triggering CI on branch 'release-next' after synching to upstream/master
…#240) For two reasons: * some tests might not use environment.Managed(t) so the test namespace won't be deleted after test * the REKT framework now doesn't delete a test namespace by default when the test fails, so when some tests fail this check would be timing out incorrectly
Fixes #209
Proposed Changes
knative-eventingcalledflow-controller-configdefault-cluster-buskey of configmapPosting early to get some feedback before going too far.